Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] [remote merge] support netty for remote merge. #2173

Closed
3 tasks done
zhengchenyu opened this issue Oct 12, 2024 · 0 comments · Fixed by #2202
Closed
3 tasks done

[FEATURE] [remote merge] support netty for remote merge. #2173

zhengchenyu opened this issue Oct 12, 2024 · 0 comments · Fixed by #2202

Comments

@zhengchenyu
Copy link
Collaborator

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the feature

support netty for remote merge.

Motivation

No response

Describe the solution

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@zhengchenyu zhengchenyu mentioned this issue Oct 18, 2024
Merged
zhengchenyu added a commit to zhengchenyu/incubator-uniffle that referenced this issue Oct 18, 2024
@zhengchenyu
[apache#2173] feat(remote merge): support netty for remote merge.
7826b16
@zhengchenyu zhengchenyu mentioned this issue Oct 18, 2024
Merged
zhengchenyu added a commit to zhengchenyu/incubator-uniffle that referenced this issue Oct 21, 2024
@zhengchenyu
[apache#2173] feat(remote merge): support netty for remote merge.
3a68303
zhengchenyu added a commit that referenced this issue Oct 22, 2024
@zhengchenyu
[#2173] feat(remote merge): support netty for remote merge. (#2202)
5dda112 
### What changes were proposed in this pull request?

Support netty for remote merge. Use direct ByteBuf to replace with byte[] when netty is enable. And optimized code structure to avoid memory leaks

### Why are the changes needed?

Fix: #2173

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

unit test, integration test, real job in cluster.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#2173] feat(remote merge): support netty for remote merge. zhengchenyu/incubator-uniffle
1 participant
@zhengchenyu