Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIR] Introduce BufferLoad/Store #5205

Merged
merged 1 commit into from
Apr 2, 2020
Merged

[TIR] Introduce BufferLoad/Store #5205

merged 1 commit into from
Apr 2, 2020

Conversation

tqchen
Copy link
Member

@tqchen tqchen commented Apr 1, 2020

Co-authored-by: Siyuan Feng hzfengsy@sjtu.edu.cn

This PR introduces BufferLoad/Store to TIR. The new nodes will replace
Provide and Call with Tensor arguments in the subsequent refactors.

@tqchen
Copy link
Member Author

tqchen commented Apr 1, 2020

Co-authored-by: Siyuan Feng <hzfengsy@sjtu.edu.cn>

This PR introduces BufferLoad/Store to TIR. The new nodes will replace
Provide and Call with Tensor arguments in the subsequent refactors.
@Hzfengsy
Copy link
Member

Hzfengsy commented Apr 2, 2020

Did you push the wrong code to this branch? The codes are same as another PR

@tqchen
Copy link
Member Author

tqchen commented Apr 2, 2020

@Hzfengsy sorry, just fixed

@tqchen tqchen merged commit 88d2f34 into apache:master Apr 2, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Apr 16, 2020
Co-authored-by: Siyuan Feng <hzfengsy@sjtu.edu.cn>

This PR introduces BufferLoad/Store to TIR. The new nodes will replace
Provide and Call with Tensor arguments in the subsequent refactors.
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Apr 17, 2020
Co-authored-by: Siyuan Feng <hzfengsy@sjtu.edu.cn>

This PR introduces BufferLoad/Store to TIR. The new nodes will replace
Provide and Call with Tensor arguments in the subsequent refactors.
@tqchen tqchen deleted the buffer branch April 21, 2020 00:01
* Disallow all IterVar manipulations and compute_at
*
* \note This is usually used to implement composite op
* or external op, where the

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment here seems incomplete, not sure about what kind of constraints these ops have led to opaque iter var.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants