Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesigning the workflow showing method #18

Merged
merged 105 commits into from
Jul 5, 2016
Merged

Conversation

sagar15795
Copy link
Member

@sagar15795 sagar15795 commented Jun 16, 2016

Workflow List [Done]

  • Design UI for WorkFlows.
  • Add Retrofit Network Request in ApiManager
  • Add ApiManger wiring with the DataManager.
  • Add Network call in WorkFlows Presenter (Logic class) class and showing in RecyclerView.

Detail Workflow [WIP]

  • Design UI for Detail WorkFlow.
  • Add Retrofit Network Request in ApiManager for Detail Workflow
  • Add ApiManger wiring with the DataManager for Detail Workflow.
  • Add Network call in DetailWorkFlow Presenter (Logic class) class and show it in UI .
  • Add favourite FAB with working
  • Add Workflow's Licence in overflow menu

Add zoom functionality to workflow image [will add it in next PR]

@therajanmaurya
Copy link
Member

@sagar15795 your build is failing. Please before push, run Gradle check.

@ianwdunlop
Copy link
Contributor

There seem to be more and more commits being pushed into this pull request. @sagar15795 you will need to tell us when to merge. It's great that you are adding all these things but it's getting too hard for me to follow all of this. Looking at the original comment in this thread there were a number of features being added/changed - are these still the things you are working on or have there been more? Anyway, at some point you need to stop adding things here, get us to check it and then (assuming it is all ok and we have merged it) you can work on more features in another pull request.

@therajanmaurya
Copy link
Member

therajanmaurya commented Jul 4, 2016

@sagar15795 I hope your Favorite logic is finished today as we have talked today. Please Let me know for review and Stop working on this.

anything has any little bug or incompleteness Please Note down and we will do that in next PR

Thanks

@sagar15795
Copy link
Member Author

I have done with all checked field.

@therajanmaurya @ianwdunlop
You can review it .
Tell me if there is any suggestion or change .

I will add licence after your review.

Thanks .

@sagar15795 sagar15795 changed the title [WIP]Redesigning the workflow showing method Redesigning the workflow showing method Jul 4, 2016
@therajanmaurya
Copy link
Member

therajanmaurya commented Jul 5, 2016

@sagar15795 some functionality is missing. we will add in next PR.
👍 Good Work.

@ianwdunlop @stain Please Merge This PR. So @sagar15795 will finish this feature because this PR is the base PR of this feature.

@sagar15795
Copy link
Member Author

I have added ASF header in all modified or added file.

@ianwdunlop @stain
Now you can merge it.

@asfgit asfgit merged commit fb8e098 into apache:master Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants