Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "refactor: Remove usages of reactable from TimeTable" #11150

Merged
merged 1 commit into from
Oct 3, 2020

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Oct 3, 2020

Reverts #11046

Fixes: #11142

This is a significant data quality issue where filters are shown as applying to the chart, but not applied to the query itself. therefore reverting from master seems prudent

to: @michellethomas @rusackas @john-bodley

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This reverts commit f01b8a3.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format your PR title to match: ^(build|chore|ci|docs|feat|fix|perf|refactor|style|test|other)((.+))?:\s.+!

@etr2460 etr2460 changed the title Revert "refactor: Remove usages of reactable from TimeTable" fix: Revert "refactor: Remove usages of reactable from TimeTable" Oct 3, 2020
@github-actions github-actions bot dismissed their stale review October 3, 2020 04:26

All good!

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this can be fixed fairly quickly. Thanks for catching.

@etr2460
Copy link
Member Author

etr2460 commented Oct 3, 2020

Thanks for the quick review! I don't think it'll be a hard fix, but I always prefer to keep master in a stable shape as often as possible

@etr2460 etr2460 merged commit 3d76f81 into master Oct 3, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@amitmiran137 amitmiran137 deleted the revert-11046-reactable/timetable branch March 29, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeseries Table does not update on dashboard when filters are changed
2 participants