Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1244 "Migrate to JUnit 5" #1245

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Fix #1244 "Migrate to JUnit 5" #1245

merged 1 commit into from
Jun 21, 2024

Conversation

rzo1
Copy link
Contributor

@rzo1 rzo1 commented Jun 18, 2024

For all changes:

  • Is there a issue associated with this PR? Is it referenced in the commit message?

  • Does your PR title start with #XXXX where XXXX is the issue number you are trying to resolve?

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

  • Is the code properly formatted with mvn git-code-format:format-code -Dgcf.globPattern="**/*" -Dskip.format.code=false?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean verify?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file?

Note:

Note: Tests were auto-converted via https://github.com/junit-pioneer/convert-junit4-to-junit5

Fix #1241 "Ensure SC can be build without a Docker environment"
@jnioche jnioche merged commit 5b77247 into main Jun 21, 2024
7 checks passed
@jnioche jnioche deleted the junit5 branch June 21, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to JUnit 5 Ensure SC can be build without a Docker environment
2 participants