1024 Playwright protocol implementation, fixes #1024 #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Nioche <julien@digitalpebble.com>
rzo1
approved these changes
May 17, 2024
| @@ -136,6 +136,7 @@ List of third-party dependencies grouped by their license type. | |||
| * FindBugs-jsr305 (com.google.code.findbugs:jsr305:3.0.2 - http://findbugs.sourceforge.net/) | |||
| * Google Android Annotations Library (com.google.android:annotations:4.1.1.4 - http://source.android.com/) | |||
| * Graphite Integration for Metrics (io.dropwizard.metrics:metrics-graphite:3.2.6 - http://metrics.dropwizard.io/metrics-graphite/) | |||
| * Gson (com.google.code.gson:gson:2.8.9 - https://github.com/google/gson/gson) | |||
There was a problem hiding this comment.
I think, that something is leaking gson here. Maybe we can fix to 2.9.0 ?
There was a problem hiding this comment.
Not sure what generates it.
mvn dependency:tree
[INFO] org.apache.stormcrawler:stormcrawler-playwright:jar:3.1.0-SNAPSHOT
[INFO] +- com.microsoft.playwright:playwright:jar:1.43.0:compile
[INFO] | +- com.google.code.gson:gson:jar:2.10.1:compile
[INFO] | +- org.opentest4j:opentest4j:jar:1.3.0:compile
Maybe it came from using an older version of playwright but then it would be removed from THIRD PARTY when calling mvn clean install ?
|
A great addition to SC! |
* Implements a unit test to actually test that playwright is rendering HTML/JS content correctly. Adds an option to specify wait until state to ensure JS is executed properly Removes PDF test, which was a "false friend" because it was returned by the mock server with an HTML mimetype and the actual returned PDF object was corrupted. * Skip playwright tests in CI as GH action cannot execute them due to missing libs * Fix formatting
rzo1
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Apache StormCrawler.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
[ x] Is there a issue associated with this PR? Is it referenced in the commit message?
[x ] Does your PR title start with
#XXXXwhereXXXXis the issue number you are trying to resolve?[x ] Has your PR been rebased against the latest commit within the target branch (typically main)?
[ x] Is your initial contribution a single, squashed commit?
[ x] Is the code properly formatted with
mvn git-code-format:format-code -Dgcf.globPattern="**/*" -Dskip.format.code=false?For code changes:
mvn clean verify?Note:
Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.