#1209 fix for emulation error in tests run on silicon #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzo1
approved these changes
May 4, 2024
| @@ -51,7 +51,8 @@ public class ProtocolTest extends AbstractProtocolTest { | |||
| private static final Logger LOG = LoggerFactory.getLogger(ProtocolTest.class); | |||
|
|
|||
| private static final DockerImageName SELENIUM_IMAGE = | |||
| DockerImageName.parse("selenium/standalone-chrome:120.0"); | |||
| DockerImageName.parse("seleniarm/standalone-chromium:latest") | |||
There was a problem hiding this comment.
Wonder if we can use a fixed tag? Reasoning would be, that "latest" can vary between environments / runs making reproducability difficult.
There was a problem hiding this comment.
Thanks for catching, @rzo1 . I meant to be explicit on a version number but forgot to switch it before committing 🤦 . It should be addressed now
|
Thx @joshfischer1108 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the container emulation issue referenced in #1209
For all changes:
Is there a issue associated with this PR? Is it referenced in the commit message?
Does your PR title start with
#XXXXwhereXXXXis the issue number you are trying to resolve?Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
Is the code properly formatted with
mvn git-code-format:format-code -Dgcf.globPattern=**/*?For code changes:
mvn clean verify?Note:
Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.