#1049 Replace "Collapse and Expand Results" Solr query with "Result Grouping" query.

[syefimov]

Ticket #1049
Replace "Collapse and Expand Results" Solr query with "Result Grouping" query.

[jnioche]

thanks for the PR @syefimov

I would have been better to have one PR per issue. For instance, the addition of the DeletionBolt could be done while discussing / refining the other PR.

You have ignored my comment about the license header, your commits are not signed, the title of the PR is not indicative of what it does and the formatting recommendation (simply call 'mvn git-code-format:format-code -Dgcf.globPattern=**/*') seem not to have been followed.

Would you mind having another try? Thanks!

[syefimov]

I will do it over weekend. thank you.

…

________________________________ From: Julien Nioche ***@***.***> Sent: Thursday, April 6, 2023 11:35 AM To: DigitalPebble/storm-crawler ***@***.***> Cc: Sergey Yefimov ***@***.***>; Mention ***@***.***> Subject: Re: [DigitalPebble/storm-crawler] Update SolrSpout.java (PR #1053) thanks for the PR @syefimov<https://github.com/syefimov> I would have been better to have one PR per issue. For instance, the addition of the DeletionBolt could be done while discussing / refining the other PR. You have ignored my comment about the license header, your commits are not signed, the title of the PR is not indicative of what it does and the formatting recommendation (simply call 'mvn git-code-format:format-code -Dgcf.globPattern=**/*') seem not to have been followed. Would you mind having another try? Thanks! — Reply to this email directly, view it on GitHub<#1053 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABSIOA3TE5UTTTMHUYTHRYLW73PFVANCNFSM6AAAAAAWVOCORU>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[syefimov]

I removed DeletionBolt.java, committed (signed) formatted SolrSpout.java. I should create a separate branch for this commit in my repository. Will do it in a right way for a next one.
Thank you.

[jnioche]

looks way better, thanks @syefimov

I don't think the formatting has been applied. Could you please run
mvn git-code-format:format-code -Dgcf.globPattern=**/
and push?

Would have been nice to be able to reproduce the problem that this PR is fixing but this would require #851 first

[jnioche]

Hi @syefimov, how can I help you make progress on this PR?

[syefimov]

Julien, I was way to busy lately. I will try to finish it on weekends. Sorry.

…

________________________________ From: Julien Nioche ***@***.***> Sent: Thursday, April 27, 2023 11:02 AM To: DigitalPebble/storm-crawler ***@***.***> Cc: Sergey Yefimov ***@***.***>; Mention ***@***.***> Subject: Re: [DigitalPebble/storm-crawler] #1049 Replace "Collapse and Expand Results" Solr query with "Result Grouping" query. (PR #1053) Hi @syefimov<https://github.com/syefimov>, how can I help you make progress on this PR? — Reply to this email directly, view it on GitHub<#1053 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABSIOA3OOCVMRVNCJNQUMODXDKC6ZANCNFSM6AAAAAAWVOCORU>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[syefimov]

I put changes to the grouping query code, run formatting script again and committed changes. Hope it will work this time.

[jnioche]

thanks a lot @syefimov, this is great