Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files in jars have odd dates #1300

Closed
pjfanning opened this issue Sep 15, 2024 · 3 comments
Closed

files in jars have odd dates #1300

pjfanning opened this issue Sep 15, 2024 · 3 comments
Assignees
Milestone

Comments

@pjfanning
Copy link
Contributor

I checked the 3.1.0 RC jars and the files in stormcrawler-core-3.1.0.jar all had this date.

07-04-2024

I am in favour of reproducible builds meaning that files in jar may not have today's date but this date is confusing. Many reproducible builds just go with 01-01-1970 dates or some date hardcoded in build but that might reflect some date around the release (as long as the date is hardcoded in the source release so that all builds have this date regardless of when the build with that release is run.

@rzo1
Copy link
Contributor

rzo1 commented Sep 15, 2024

Don't think we set it explicitly, so working towards reproducable builds would be good anyway.

@pjfanning
Copy link
Contributor Author

How did we end up with 7 April or 4 July as the date? (I'm not sure if the date in the file is in International or in US format)

@rzo1
Copy link
Contributor

rzo1 commented Sep 15, 2024

Guess it is a side effect from Apache Parent. Didn't dig into it though.

@rzo1 rzo1 added this to the 3.1.1 milestone Sep 24, 2024
@rzo1 rzo1 self-assigned this Sep 26, 2024
rzo1 added a commit that referenced this issue Sep 26, 2024
@rzo1 rzo1 closed this as completed Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants