Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:Fixed the issue of failing to parse annotations in TCC mode when the business object is a proxy object. #7107

Open
wants to merge 5 commits into
base: 2.x
Choose a base branch
from

Conversation

wxrqforever
Copy link

@wxrqforever wxrqforever commented Jan 13, 2025

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

#7047

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@xingfudeshi xingfudeshi added the first-time contributor first-time contributor label Jan 14, 2025
@wxrqforever
Copy link
Author

@xingfudeshi 老哥 这里再帮忙看看 我还需要做些什么吗 多谢🌹

@xingfudeshi
Copy link
Member

xingfudeshi commented Jan 16, 2025

@xingfudeshi 老哥 这里再帮忙看看 我还需要做些什么吗 多谢🌹

image

@xingfudeshi xingfudeshi self-requested a review January 16, 2025 03:31
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit test does not pass, please fix it. Also, please add this PR to the change log.

@wxrqforever
Copy link
Author

@xingfudeshi 老哥 这里我处理好了 帮忙再看看 另外我有个问题想请教一下 这里跑的workflow是等价于mvn clean test吗?我在本地跑的test没法复现这里的问题,反而有其他失败的单测用例,请问有遇到过类似问题吗?

@xingfudeshi
Copy link
Member

@xingfudeshi 老哥 这里我处理好了 帮忙再看看 另外我有个问题想请教一下 这里跑的workflow是等价于mvn clean test吗?我在本地跑的test没法复现这里的问题,反而有其他失败的单测用例,请问有遇到过类似问题吗?

Yes.The workflow will run the following command:

./mvnw -T 4C clean test \
                 -Dcheckstyle.skip=false -Dpmd.skip=false -Dlicense.skip=false -DredisCaseEnabled=true \
                 -e -B -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn;

For details, Please refer to https://github.com/apache/incubator-seata/blob/2.x/.github/workflows/build.yml

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 53.16%. Comparing base (4632770) to head (faf5a2f).

Files with missing lines Patch % Lines
...m/tcc/interceptor/TccActionInterceptorHandler.java 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #7107      +/-   ##
============================================
+ Coverage     53.08%   53.16%   +0.08%     
- Complexity     6795     6803       +8     
============================================
  Files          1136     1136              
  Lines         40341    40345       +4     
  Branches       4723     4724       +1     
============================================
+ Hits          21416    21451      +35     
+ Misses        16885    16850      -35     
- Partials       2040     2044       +4     
Files with missing lines Coverage Δ
...interceptor/parser/TccActionInterceptorParser.java 73.33% <100.00%> (+0.60%) ⬆️
...m/tcc/interceptor/TccActionInterceptorHandler.java 65.38% <25.00%> (-1.29%) ⬇️

... and 5 files with indirect coverage changes

@wxrqforever
Copy link
Author

@xingfudeshi 老哥 这里我处理好了 帮忙再看看 另外我有个问题想请教一下 这里跑的workflow是等价于mvn clean test吗?我在本地跑的test没法复现这里的问题,反而有其他失败的单测用例,请问有遇到过类似问题吗?

Yes.The workflow will run the following command:

./mvnw -T 4C clean test \
                 -Dcheckstyle.skip=false -Dpmd.skip=false -Dlicense.skip=false -DredisCaseEnabled=true \
                 -e -B -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn;

For details, Please refer to https://github.com/apache/incubator-seata/blob/2.x/.github/workflows/build.yml

多谢老哥,这里还有我需要修改的地方吗,我看单测都通过,覆盖率的部分需要修改吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants