Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: alter the print info in ConfigurationFactory.java when load ExtConfiguration #7040

Merged
merged 2 commits into from
Dec 1, 2024

Conversation

LegGasai
Copy link
Contributor

@LegGasai LegGasai commented Dec 1, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

#6956

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.83%. Comparing base (a60588a) to head (c41f1b6).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
.../org/apache/seata/config/ConfigurationFactory.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #7040   +/-   ##
=========================================
  Coverage     52.83%   52.83%           
+ Complexity     6658     6656    -2     
=========================================
  Files          1128     1128           
  Lines         40142    40142           
  Branches       4707     4705    -2     
=========================================
  Hits          21210    21210           
  Misses        16920    16920           
  Partials       2012     2012           
Files with missing lines Coverage Δ
.../org/apache/seata/config/ConfigurationFactory.java 39.47% <0.00%> (ø)

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 70b4fc0 into apache:2.x Dec 1, 2024
7 checks passed
@slievrly slievrly added this to the 2.3.0 milestone Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants