Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve unit test coverage of seata-tm moudle #7018

Merged
merged 9 commits into from
Nov 22, 2024

Conversation

YvCeung
Copy link
Contributor

@YvCeung YvCeung commented Nov 20, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Add unit test cases to complete the unit testing objectives for the seata-tm module.
增加单元测试用例,完成 seata-tm模块的单元测试目标

Ⅱ. Does this pull request fix one issue?

fix #6837

Ⅲ. Why don't you add test cases (unit test/integration test)?

Not applicable.
不适用

Ⅳ. Describe how to verify it

Run mvn clean test

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added TM Relate to seata tm first-time contributor first-time contributor module/tm tm module type: test test case labels Nov 21, 2024
@funky-eyes funky-eyes added this to the 2.x Backlog milestone Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.61%. Comparing base (289f07d) to head (510f307).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #7018      +/-   ##
============================================
+ Coverage     52.52%   52.61%   +0.08%     
- Complexity     6577     6593      +16     
============================================
  Files          1126     1126              
  Lines         40007    40007              
  Branches       4696     4694       -2     
============================================
+ Hits          21015    21051      +36     
+ Misses        16984    16948      -36     
  Partials       2008     2008              

see 8 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YvCeung YvCeung requested review from xjlgod and funky-eyes November 21, 2024 14:21
@funky-eyes funky-eyes modified the milestones: 2.x Backlog, 2.3.0 Nov 22, 2024
@funky-eyes funky-eyes changed the title optimize: improve unit test coverage of seata-tm moudle test: improve unit test coverage of seata-tm moudle Nov 22, 2024
@funky-eyes funky-eyes merged commit a3fd17c into apache:2.x Nov 22, 2024
5 checks passed
@YvCeung YvCeung deleted the improve_ut_coverage_24_1117 branch November 22, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor module/tm tm module TM Relate to seata tm type: test test case
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve test coverage
3 participants