-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: improve unit test coverage of seata-tm moudle #7018
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xjlgod
reviewed
Nov 20, 2024
tm/src/test/java/org/apache/seata/tm/DefaultTransactionManagerTest.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7018 +/- ##
============================================
+ Coverage 52.52% 52.61% +0.08%
- Complexity 6577 6593 +16
============================================
Files 1126 1126
Lines 40007 40007
Branches 4696 4694 -2
============================================
+ Hits 21015 21051 +36
+ Misses 16984 16948 -36
Partials 2008 2008
|
funky-eyes
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
first-time contributor
first-time contributor
module/tm
tm module
TM
Relate to seata tm
type: test
test case
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Add unit test cases to complete the unit testing objectives for the
seata-tm
module.增加单元测试用例,完成 seata-tm模块的单元测试目标
Ⅱ. Does this pull request fix one issue?
fix #6837
Ⅲ. Why don't you add test cases (unit test/integration test)?
Not applicable.
不适用
Ⅳ. Describe how to verify it
Run
mvn clean test
Ⅴ. Special notes for reviews