Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize lock release logic in AT transaction mode #6996

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

slievrly
Copy link
Member

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

optimize lock release logic in AT transaction mode

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.3.0 milestone Nov 15, 2024
@funky-eyes funky-eyes added mode: AT AT transaction mode module/server server module type: optimize labels Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 47.05882% with 9 lines in your changes missing coverage. Please review.

Project coverage is 52.65%. Comparing base (f195eb9) to head (bb9972a).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...e/seata/server/coordinator/DefaultCoordinator.java 37.50% 2 Missing and 3 partials ⚠️
...e/seata/server/session/AbstractSessionManager.java 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6996      +/-   ##
============================================
+ Coverage     52.60%   52.65%   +0.05%     
- Complexity     6578     6584       +6     
============================================
  Files          1126     1126              
  Lines         39922    39928       +6     
  Branches       4680     4680              
============================================
+ Hits          20999    21026      +27     
+ Misses        16920    16898      -22     
- Partials       2003     2004       +1     
Files with missing lines Coverage Δ
...ava/org/apache/seata/common/ConfigurationKeys.java 0.00% <ø> (ø)
...in/java/org/apache/seata/common/DefaultValues.java 0.00% <ø> (ø)
...g/apache/seata/server/coordinator/DefaultCore.java 51.70% <100.00%> (ø)
...e/seata/server/session/AbstractSessionManager.java 59.45% <20.00%> (+0.03%) ⬆️
...e/seata/server/coordinator/DefaultCoordinator.java 45.59% <37.50%> (-0.15%) ⬇️

... and 6 files with indirect coverage changes

@funky-eyes funky-eyes merged commit dbe095a into apache:2.x Nov 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mode: AT AT transaction mode module/server server module type: optimize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants