Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add fastjson2 undolog parser #6974

Merged
merged 5 commits into from
Nov 4, 2024

Conversation

GoodBoyCoder
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

add support for UndoLog serialization type of FastJson2

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Change the serialization configuration of undolog[undo.logSerialization] to fastjson2

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.67%. Comparing base (5d2b139) to head (38a20cc).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...datasource/undo/parser/Fastjson2UndoLogParser.java 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6974      +/-   ##
============================================
+ Coverage     52.64%   52.67%   +0.02%     
- Complexity     6565     6571       +6     
============================================
  Files          1124     1125       +1     
  Lines         39915    39923       +8     
  Branches       4675     4677       +2     
============================================
+ Hits          21015    21029      +14     
+ Misses        16898    16893       -5     
+ Partials       2002     2001       -1     
Files with missing lines Coverage Δ
...datasource/undo/parser/Fastjson2UndoLogParser.java 87.50% <87.50%> (ø)

... and 5 files with indirect coverage changes

@funky-eyes funky-eyes added this to the 2.3.0 milestone Nov 3, 2024
@funky-eyes funky-eyes added type: feature Category issues or prs related to feature request. module/rm-datasource rm-datasource module labels Nov 3, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes changed the title feat: add fastjson2 undolog parser feature: add fastjson2 undolog parser Nov 4, 2024
@funky-eyes funky-eyes merged commit 363e179 into apache:2.x Nov 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module type: feature Category issues or prs related to feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants