Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: modify seata-http-jakarta's name and description in pom.xml #6959

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

psxjoy
Copy link
Contributor

@psxjoy psxjoy commented Oct 29, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Rename seata-http-jakarta module maven name and description.

Ⅱ. Does this pull request fix one issue?

resolve #6939

Ⅲ. Why don't you add test cases (unit test/integration test)?

Not applicable.

Ⅳ. Describe how to verify it

Run mvn install -DskipTests,and see seata-http-jarkarta.jar.

Ⅴ. Special notes for reviews

No.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.68%. Comparing base (3de2382) to head (80bfbee).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6959      +/-   ##
============================================
- Coverage     52.71%   52.68%   -0.04%     
+ Complexity     6560     6558       -2     
============================================
  Files          1122     1122              
  Lines         39864    39864              
  Branches       4669     4667       -2     
============================================
- Hits          21016    21001      -15     
- Misses        16849    16866      +17     
+ Partials       1999     1997       -2     

see 6 files with indirect coverage changes

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.3.0 milestone Oct 29, 2024
@funky-eyes funky-eyes merged commit 37b8418 into apache:2.x Oct 29, 2024
7 checks passed
@psxjoy psxjoy deleted the change-module-pom-name branch October 29, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Same maven name with two modules
2 participants