optimize: remove JVM parameter app.id #6950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xingfudeshi
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6950 +/- ##
============================================
- Coverage 52.68% 52.68% -0.01%
+ Complexity 6559 6558 -1
============================================
Files 1122 1122
Lines 39864 39864
Branches 4667 4667
============================================
- Hits 21004 21003 -1
- Misses 16864 16865 +1
Partials 1996 1996 |
slievrly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
The pid passed in by -Dapp.pid=${$} is actually the pid of seata-server.sh, not the java process id of seata-server; at the same time, it is impossible to get the pid of the current java process when starting seata-server, so remove it.
Ⅱ. Does this pull request fix one issue?
fixes #5692
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews