Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: update online chat information in README.md #6938

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

psxjoy
Copy link
Contributor

@psxjoy psxjoy commented Oct 21, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

When I attempted to join the chat group, I noticed that some of the information was no longer valid. As a result, I updated the latest contact details (sourced from Seata's official website).

通过readme.md 加群的时候,发现:

  1. 现在的联系二维码是图片实现的,不方便后续的更新;
  2. 部分的二维码已经失效。

此PR修改了最新的联系方式(信息来源于 seata的官方网站

Ⅱ. Does this pull request fix one issue?

No.

Ⅲ. Why don't you add test cases (unit test/integration test)?

Not applicable.

Ⅳ. Describe how to verify it

Not applicable.

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.53%. Comparing base (fabccea) to head (4e228fb).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #6938   +/-   ##
=========================================
  Coverage     52.53%   52.53%           
- Complexity     6541     6543    +2     
=========================================
  Files          1122     1122           
  Lines         39858    39858           
  Branches       4666     4668    +2     
=========================================
+ Hits          20940    20941    +1     
  Misses        16925    16925           
+ Partials       1993     1992    -1     

see 4 files with indirect coverage changes

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pls add change info.

@psxjoy
Copy link
Contributor Author

psxjoy commented Oct 21, 2024

LGTM. Pls add change info.

Thanks. I have already added.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit 4223b85 into apache:2.x Oct 23, 2024
6 checks passed
@slievrly slievrly added this to the 2.3.0 milestone Oct 26, 2024
@psxjoy psxjoy deleted the 2.x-update-readme branch October 28, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants