Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: add license header for spring config file #6652

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Jul 7, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

add license header for spring config file

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.23%. Comparing base (933b492) to head (4e9db88).
Report is 32 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6652      +/-   ##
============================================
- Coverage     51.13%   50.23%   -0.90%     
- Complexity     5317     5595     +278     
============================================
  Files           950     1023      +73     
  Lines         33448    35440    +1992     
  Branches       4048     4216     +168     
============================================
+ Hits          17103    17803     +700     
- Misses        14666    15870    +1204     
- Partials       1679     1767      +88     

see 124 files with indirect coverage changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个改动会使拥有copyright的其它文件由于格式不同,而被认为没有license header
This change will cause other copyrighted files to be considered without the license header due to their different formats

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该是我误解了,可能需要#6650及#6651被合并后,才能通过该check
I must have misunderstood, it may take #6650 and #6651 to be merged to pass the check.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it need to re-run the CI status after the first two PRs are merged.

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERROR the following files don't have a valid license header:
tcc/src/main/resources/META-INF/services/org.apache.seata.integration.tx.api.json.JsonParser
ERROR one or more files does not have a valid license header

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.2.0 milestone Jul 9, 2024
@funky-eyes funky-eyes merged commit dcf63d0 into apache:2.x Jul 9, 2024
6 checks passed
slievrly added a commit to slievrly/fescar that referenced this pull request Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Process
Development

Successfully merging this pull request may close these issues.

3 participants