Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shell/sds): NULL check before memset #538

Merged
merged 2 commits into from
May 19, 2020

Conversation

l2dy
Copy link
Contributor

@l2dy l2dy commented May 18, 2020

What problem does this PR solve?

Potential use of NULL pointer.

What is changed and how it works?

Check for NULL before memset().

@l2dy
Copy link
Contributor Author

l2dy commented May 18, 2020

See also antirez/sds@6fa721c.

Alternative solution is to sync with upstream.

@acelyc111 acelyc111 changed the title shell/sds: NULL check before memset bugfix(shell/sds): NULL check before memset May 18, 2020
@acelyc111 acelyc111 changed the title bugfix(shell/sds): NULL check before memset fix(shell/sds): NULL check before memset May 18, 2020
@acelyc111 acelyc111 closed this May 19, 2020
@acelyc111 acelyc111 reopened this May 19, 2020
@acelyc111
Copy link
Member

@l2dy Thanks for your contribute!

@acelyc111 acelyc111 merged commit 520255d into apache:master May 19, 2020
@l2dy l2dy deleted the sds/malloc-null branch May 19, 2020 07:33
@neverchanje neverchanje mentioned this pull request May 28, 2020
@neverchanje neverchanje mentioned this pull request Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants