fix: fix bug in local_service #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 12, 2020 18:51
acelyc111
previously approved these changes
May 12, 2020
acelyc111
approved these changes
May 13, 2020
hycdong
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When trigger a cold backup with local_service, I found that the restore will produce error.
It is because we don't specific a path for local service, so the checkpoint will placement at the relative path of each replica.
Here we show one an example for the director of replica1 with local_service
replica1/onebox/policy/1589281927550/temp_2. And for replica2, it may bereplica2/onebox/policy/1589281927550/temp_2. I mean these checkpoint files are stored separately in different directories.Then if you restore a specific partition, we don't know how to find the checkpoint files. And it will produce restore error.
So we need to Specify a path for local_service.