-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement(lb): add add_node_list.sh to add nodes with copy_pri after all copy_sec done #528
Merged
foreverneverer
merged 16 commits into
apache:master
from
foreverneverer:shell-online-node
May 9, 2020
Merged
improvement(lb): add add_node_list.sh to add nodes with copy_pri after all copy_sec done #528
foreverneverer
merged 16 commits into
apache:master
from
foreverneverer:shell-online-node
May 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
May 6, 2020
foreverneverer
force-pushed
the
shell-online-node
branch
from
May 6, 2020 08:03
ad76a5e
to
1533bc9
Compare
acelyc111
previously approved these changes
May 7, 2020
neverchanje
reviewed
May 9, 2020
neverchanje
reviewed
May 9, 2020
format Co-authored-by: Wu Tao <wutao1@xiaomi.com>
Co-authored-by: Wu Tao <wutao1@xiaomi.com>
Co-authored-by: Wu Tao <wutao1@xiaomi.com>
neverchanje
reviewed
May 9, 2020
neverchanje
approved these changes
May 9, 2020
neverchanje
changed the title
feat: add online_node_list script to add new nodes with coping secondary preferentially
improvement(lb): add add_node_list.sh to add nodes with copy_pri after all copy_sec done
May 9, 2020
acelyc111
approved these changes
May 9, 2020
levy5307
approved these changes
May 9, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When we add new node for cluster, the copying operation will let the new node has very high load. And then the new node almost is unavailable.
What is changed and how it works?
This pr change the default order of
copying primary preferentially
tocopying secondary preferentially
by settingonly_move_primary = true
when we add new node and recover it after completed.Before the total replica count is balanced, the new node won't have any primary until copying secondary completes. Because the new node won't serve user-requests, reads will not be influenced by the data-migration of replicas.
Check List
Tests (for the pr refactor the
offline_node_list.sh
, so need 2 manual test)Manual test for
pegasus_online_node_list.sh
(add detailed scripts or steps below)nodes -d
and the falconread
:Manual test for
pegasus_offline_node_list.sh
(add detailed scripts or steps below)running
replica server node = 5pegasus_offline_node_list.sh
and show therunning
replica server node = 4Related changes