fix(collector): no validate the app_name after parse_app_perf_counter_name #514
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related Coredump
Reason
#499 add
parse_app_perf_counter_name
to parseperf_counter_name
, but no check whether the app_name fromperf_counter_name
is existed indsn::app_status::AS_AVAILABLE
type apps. for example, the app was dropped and the app_name should be ignored, otherwise the code line 783 will get error result and crash at line 784.https://github.com/XiaoMi/pegasus/blob/1a1fc190d9eac42ce359dc356483ae06d583ab8b/src/shell/command_helper.h#L781-L785
What is changed and how it works?
Check if the app_name existed.
Check List
Tests
temp
app) has the perf-counter.temp
app.collector
crash and generatecore dump
file after runnning for a while.collector
runs well and nocore dump
file.Related changes