Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include key size while calculating capacity units #504

Merged
merged 28 commits into from
Apr 8, 2020
Merged

fix: include key size while calculating capacity units #504

merged 28 commits into from
Apr 8, 2020

Conversation

foreverneverer
Copy link
Contributor

@foreverneverer foreverneverer commented Mar 26, 2020 •
edited
Loading

What problem does this PR solve?

Check List

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation about capacity unit
  • Need to be included in the release note

@foreverneverer foreverneverer mentioned this pull request Mar 26, 2020
Merged
@neverchanje neverchanje changed the title refactor: change the way to calculate cu fix: include key size while calculating capacity units Mar 30, 2020
acelyc111
acelyc111 reviewed Apr 7, 2020
View reviewed changes
src/server/capacity_unit_calculator.cpp Outdated Show resolved Hide resolved
src/server/capacity_unit_calculator.cpp Show resolved Hide resolved
src/server/capacity_unit_calculator.cpp Outdated Show resolved Hide resolved
@acelyc111 acelyc111 merged commit 6516ff4 into apache:master Apr 8, 2020
@neverchanje neverchanje mentioned this pull request May 14, 2020
Closed
@neverchanje neverchanje mentioned this pull request Jun 10, 2020
Closed
acelyc111 pushed a commit that referenced this pull request Jun 23, 2022
refactor: move rpc module to a separated directory (#504)
065c1ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levy5307 levy5307 levy5307 left review comments

@neverchanje neverchanje neverchanje left review comments

@hycdong hycdong hycdong approved these changes

@acelyc111 acelyc111 acelyc111 approved these changes

Assignees
No one assigned
Labels
v2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@foreverneverer @neverchanje @acelyc111 @hycdong @levy5307