Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell: use rocksdb's histogram for shell key-value size statistics #216

Merged
merged 4 commits into from
Nov 16, 2018

Conversation

acelyc111
Copy link
Member

@acelyc111 acelyc111 commented Nov 15, 2018

we can see more key/value size statistics now.
the key/value size statistics part of output of shell command count_data -z will look like:

INFO: split[0]: 103800 rows
INFO: split[1]: 68900 rows
INFO: split[2]: 75700 rows
INFO: split[3]: 55200 rows
Count partially, total 303600 rows.

[hash_key_size]
    max = 32
    med = 32.00
    avg = 32.00
    min = 32
    P99 = 32.00
    P95 = 32.00
    P90 = 32.00
[sort_key_size]
    max = 13
    med = 13.00
    avg = 13.00
    min = 13
    P99 = 13.00
    P95 = 13.00
    P90 = 13.00
[value_size]
    max = 155004
    med = 1714.41
    avg = 3233.96
    min = 999
    P99 = 21555.07
    P95 = 11357.16
    P90 = 7609.97
[row_size]
    max = 155049
    med = 1726.63
    avg = 3278.96
    min = 1044
    P99 = 21584.27
    P95 = 11409.80
    P90 = 7662.66

@acelyc111 acelyc111 added the component/shell pegasus shell label Nov 15, 2018
qinzuoyan
qinzuoyan previously approved these changes Nov 15, 2018
@@ -10,7 +10,13 @@ set(MY_PROJ_SRC "linenoise/linenoise.c" "sds/sds.c")
# "GLOB" for non-recursive search
set(MY_SRC_SEARCH_MODE "GLOB")

set(MY_PROJ_INC_PATH "../include" "../base")
set(MY_PROJ_INC_PATH
Copy link
Contributor

@neverchanje neverchanje Nov 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其实我意思是在 src/CMakeList.txt 里改...不用 MY_PROJ_INC_PATH

include_directories(${CMAKE_CURRENT_SOURCE_DIR})
include_directories(${CMAKE_CURRENT_SOURCE_DIR}/include)
include_directories(${PEGASUS_PROJECT_DIR}/rocksdb/include)
include_directories(${PEGASUS_ROOT}/include)

+ include_directories(${PEGASUS_PROJECT_DIR}/rocksdb/)

也可以我先过了,以后我再整

@acelyc111 acelyc111 merged commit 590ce92 into apache:master Nov 16, 2018
acelyc111 added a commit that referenced this pull request Dec 14, 2018
)

* shell command `count_data -z` could show more information, such as key/value/row size median, p99, p95, etc.
neverchanje pushed a commit to neverchanje/pegasus that referenced this pull request Jul 13, 2019
…pache#216)

* shell command `count_data -z` could show more information, such as key/value/row size median, p99, p95, etc.


Former-commit-id: eca002fe9bfcea8e774c4710276d3c0bbca71794 [formerly 590ce92]
Former-commit-id: 4622539da61e47d971fcb762378704b69e802d4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/shell pegasus shell
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants