-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shell: use rocksdb's histogram for shell key-value size statistics #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinzuoyan
previously approved these changes
Nov 15, 2018
neverchanje
reviewed
Nov 16, 2018
neverchanje
reviewed
Nov 16, 2018
@@ -10,7 +10,13 @@ set(MY_PROJ_SRC "linenoise/linenoise.c" "sds/sds.c") | |||
# "GLOB" for non-recursive search | |||
set(MY_SRC_SEARCH_MODE "GLOB") | |||
|
|||
set(MY_PROJ_INC_PATH "../include" "../base") | |||
set(MY_PROJ_INC_PATH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
其实我意思是在 src/CMakeList.txt 里改...不用 MY_PROJ_INC_PATH
include_directories(${CMAKE_CURRENT_SOURCE_DIR})
include_directories(${CMAKE_CURRENT_SOURCE_DIR}/include)
include_directories(${PEGASUS_PROJECT_DIR}/rocksdb/include)
include_directories(${PEGASUS_ROOT}/include)
+ include_directories(${PEGASUS_PROJECT_DIR}/rocksdb/)
也可以我先过了,以后我再整
neverchanje
approved these changes
Nov 16, 2018
qinzuoyan
approved these changes
Nov 16, 2018
neverchanje
pushed a commit
to neverchanje/pegasus
that referenced
this pull request
Jul 13, 2019
…pache#216) * shell command `count_data -z` could show more information, such as key/value/row size median, p99, p95, etc. Former-commit-id: eca002fe9bfcea8e774c4710276d3c0bbca71794 [formerly 590ce92] Former-commit-id: 4622539da61e47d971fcb762378704b69e802d4b
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can see more key/value size statistics now.
the key/value size statistics part of output of shell command
count_data -z
will look like: