feat(replica): close the replica and mark the dir_node as IO_ERROR when encounter read/write IO error #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
force-pushed
the
non_recoverable_rdb_err
branch
2 times, most recently
from
70ed3cf to
c97692e
Compare
acelyc111
force-pushed
the
non_recoverable_rdb_err
branch
from
c97692e to
0d33aca
Compare
empiredan
pushed a commit
that referenced
this pull request
May 26, 2023
#1383 In prior implemention, every replica has a "dir_node status", if a dir_node has some abnormal status (e.g. in space insufficient), we have to update all replicas' referenced "dir_node status", it is implemented in `replica_stub::update_disks_status`. This make the "dir_node status" updating path too long, and a bit of duplicate. A new implemention is completed in #1473, every replica has a reference of dir_node directly, so it would be easy to update replcia's "dir_node status" by updating the referenced dir_node's status once. Before the new implemention, this patch submit a minor refactor to remove `replica_stub::update_disks_status` and related functions and variables. Also some unit tests have been updated.
acelyc111
force-pushed
the
non_recoverable_rdb_err
branch
2 times, most recently
from
4b57da3 to
0cb9110
Compare
Codecov Report
@@ Coverage Diff @@
## master #1473 +/- ##
=========================================
Coverage ? 53.58%
=========================================
Files ? 27
Lines ? 2538
Branches ? 0
=========================================
Hits ? 1360
Misses ? 1132
Partials ? 46 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
acelyc111
force-pushed
the
non_recoverable_rdb_err
branch
2 times, most recently
from
0317989 to
7b89eaf
Compare
acelyc111
force-pushed
the
non_recoverable_rdb_err
branch
from
e10800e to
0f5db12
Compare
acelyc111
force-pushed
the
non_recoverable_rdb_err
branch
from
0f5db12 to
3d4b881
Compare
acelyc111
changed the title
empiredan
reviewed
Jun 13, 2023
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
empiredan
approved these changes
Jun 14, 2023
levy5307
approved these changes
Jun 14, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1383
This patch deal with the IO error populated from storage engine of read and write
operations, the replica will be closed and mark the dir_node as disk_status::IO_ERROR.
The dir_node marked as IO_ERROR will not be selected when new replicas created as
patch 4dcbb1e implemented.
This patch also add/update some unit tests.