feat(test): add bench type multi set/get #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GehaFearless
force-pushed
the
liguohao_multi_bench
branch
5 times, most recently
from
6d43e4a to
7ddb15c
Compare
foreverneverer
previously approved these changes
Feb 28, 2023
GehaFearless
changed the title
GehaFearless
changed the title
Smityz
reviewed
Feb 28, 2023
acelyc111
reviewed
Feb 28, 2023
src/test/bench_test/benchmark.cpp
Outdated
| // generate value for random to keep in peace with write | ||
| for (int j = 0; j < 100; j++) { | ||
| sortkeys.insert(generate_string(FLAGS_sortkey_size)); | ||
| value = generate_string(FLAGS_value_size); |
There was a problem hiding this comment.
why overwrite value repetitive?
There was a problem hiding this comment.
Cos generate_string should be ordered make data.
Be like generate_kv_pair for read_random.
There was a problem hiding this comment.
Invoke generate_string is enough, not need to assign, and add some comments.
PS: A better way is to separate the generator function of keys and values.
GehaFearless
force-pushed
the
liguohao_multi_bench
branch
from
b2856ff to
eab4faf
Compare
GehaFearless
changed the title
acelyc111
reviewed
Mar 1, 2023
src/test/bench_test/benchmark.cpp
Outdated
| // generate value for random to keep in peace with write | ||
| for (int j = 0; j < 100; j++) { | ||
| sortkeys.insert(generate_string(FLAGS_sortkey_size)); | ||
| value = generate_string(FLAGS_value_size); |
There was a problem hiding this comment.
Invoke generate_string is enough, not need to assign, and add some comments.
PS: A better way is to separate the generator function of keys and values.
GehaFearless
force-pushed
the
liguohao_multi_bench
branch
from
e98868c to
f3a377f
Compare
GehaFearless
force-pushed
the
liguohao_multi_bench
branch
from
f3a377f to
56e1984
Compare
acelyc111
reviewed
Mar 2, 2023
acelyc111
reviewed
Mar 2, 2023
Co-authored-by: Yingchun Lai <acelyc1112009@gmail.com>
Co-authored-by: Yingchun Lai <acelyc1112009@gmail.com>
Co-authored-by: Yingchun Lai <acelyc1112009@gmail.com>
Co-authored-by: Yingchun Lai <acelyc1112009@gmail.com>
Co-authored-by: Yingchun Lai <acelyc1112009@gmail.com>
Co-authored-by: Yingchun Lai <acelyc1112009@gmail.com>
Co-authored-by: Yingchun Lai <acelyc1112009@gmail.com>
Co-authored-by: Yingchun Lai <acelyc1112009@gmail.com>
Co-authored-by: Yingchun Lai <acelyc1112009@gmail.com>
Co-authored-by: Yingchun Lai <acelyc1112009@gmail.com>
Co-authored-by: Yingchun Lai <acelyc1112009@gmail.com>
Co-authored-by: Yingchun Lai <acelyc1112009@gmail.com>
Co-authored-by: Yingchun Lai <acelyc1112009@gmail.com>
Smityz
approved these changes
Mar 2, 2023
acelyc111
approved these changes
Mar 2, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1372