refactor(conf): use DSN_DEFINE_string to load string type of configs #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smityz
reviewed
Feb 28, 2023
| _zoo_logfile = dsn_config_get_value_string("zookeeper", "logfile", "", "zookeeper logfile"); | ||
|
|
||
| FILE *fp = fopen(_zoo_logfile.c_str(), "a"); | ||
| FILE *fp = fopen(FLAGS_logfile, "a"); |
There was a problem hiding this comment.
"append", see https://cplusplus.com/reference/cstdio/fopen/
empiredan
approved these changes
Mar 1, 2023
levy5307
approved these changes
Mar 1, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1323
This patch refactors the code to use
DSN_DEFINE_stringinstead ofdsn_config_get_value_stringto load string type of configurations, and doesn't introduce any functional changes.