chore(script): Script migrate_node.sh supports using specified config file when using shell config #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
Mar 3, 2023
run.sh
Outdated
| @@ -1660,6 +1663,11 @@ function run_migrate_node() | |||
| CLUSTER="$2" | |||
| shift | |||
| ;; | |||
| -p|--config) | |||
| CONFIG="$2" | |||
| CONFIG_SPECIFIED=1 | |||
There was a problem hiding this comment.
CONFIG_SPECIFIED can be removed, just judge whether CONFIG is empty or not?
WHBANG
force-pushed
the
migrate_node_tool
branch
from
692da59 to
863a05e
Compare
|
If it's necessary to be compatible with the previous format of arguments for
|
WHBANG
force-pushed
the
migrate_node_tool
branch
from
0b0ac9d to
73a8aef
Compare
empiredan
reviewed
Mar 10, 2023
scripts/migrate_node.sh
Outdated
| if [ $# -eq 4 ]; then | ||
| cluster=$1 | ||
| else | ||
| CONFIG_SPECIFIED=1 |
There was a problem hiding this comment.
If it is necessary to check whether option is -f ?
empiredan
previously approved these changes
Mar 13, 2023
acelyc111
reviewed
Mar 13, 2023
acelyc111
approved these changes
Mar 14, 2023
empiredan
approved these changes
Mar 14, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#1368