Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(log): use LOG_ERROR_F instead of LOG_ERROR (2/2) #1320

Merged
merged 6 commits into from
Jan 19, 2023
Merged

refactor(log): use LOG_ERROR_F instead of LOG_ERROR (2/2) #1320

merged 6 commits into from
Jan 19, 2023

Conversation

WHBANG
Copy link
Contributor

@WHBANG WHBANG commented Jan 19, 2023 •
edited
Loading

What problem does this PR solve?

#1305

This patch aim to use LOG_ERROR_F instead of LOG_ERROR for all the remain parts:

  • Remove the defination of LOG_ERROR
  • Use LOG_ERROR_F instead of LOG_ERROR
  • Use LOG_ERROR_PREFIX instead of LOG_ERROR for class pegasus_server_impl
  • Some format fixes

@github-actions github-actions bot added the cpp label Jan 19, 2023
acelyc111
acelyc111 reviewed Jan 19, 2023
View reviewed changes
src/client/partition_resolver_simple.cpp Outdated Show resolved Hide resolved
src/failure_detector/failure_detector.cpp Outdated Show resolved Hide resolved
src/meta/meta_backup_service.cpp Outdated Show resolved Hide resolved
src/nfs/nfs_server_impl.cpp Outdated Show resolved Hide resolved
src/runtime/rpc/asio_net_provider.cpp Outdated Show resolved Hide resolved
acelyc111
acelyc111 reviewed Jan 19, 2023
View reviewed changes
src/client/partition_resolver_simple.cpp Outdated Show resolved Hide resolved
src/meta/meta_backup_service.cpp Outdated Show resolved Hide resolved
src/meta/meta_backup_service.cpp Outdated Show resolved Hide resolved
src/server/pegasus_server_impl.cpp Outdated Show resolved Hide resolved
@WHBANG WHBANG force-pushed the dev/refactor_log_macros_error_other branch from 0b5544b to 12c7842 Compare January 19, 2023 12:25
empiredan
empiredan reviewed Jan 19, 2023
View reviewed changes
src/runtime/rpc/network.cpp Outdated Show resolved Hide resolved
src/utils/filesystem.cpp Outdated Show resolved Hide resolved
src/meta/meta_data.cpp Outdated Show resolved Hide resolved
src/nfs/nfs_server_impl.cpp Outdated Show resolved Hide resolved
empiredan
empiredan previously approved these changes Jan 19, 2023
View reviewed changes
acelyc111
acelyc111 approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@acelyc111 acelyc111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@empiredan empiredan merged commit d17f1ff into apache:master Jan 19, 2023
@acelyc111 acelyc111 mentioned this pull request Jan 28, 2023
Closed
@empiredan empiredan mentioned this pull request Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acelyc111 acelyc111 acelyc111 approved these changes

@empiredan empiredan empiredan approved these changes

Assignees
No one assigned
Labels
cpp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WHBANG @empiredan @acelyc111