Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(log): use LOG_FATAL_F instead of LOG_FATAL #1312

Merged
merged 5 commits into from
Jan 16, 2023
Merged

refactor(log): use LOG_FATAL_F instead of LOG_FATAL #1312

merged 5 commits into from
Jan 16, 2023

Conversation

acelyc111
Copy link
Member

#1305

This patch aim to use LOG_FATAL_F instead of LOG_FATAL for all parts:

  • Remove the defination of LOG_FATAL
  • Use LOG_FATAL_F instead of LOG_FATAL

@acelyc111 acelyc111 requested a review from empiredan January 16, 2023 07:00
@github-actions github-actions bot added the cpp label Jan 16, 2023
@acelyc111 acelyc111 requested a review from Smityz January 16, 2023 07:00
@acelyc111 acelyc111 mentioned this pull request Jan 16, 2023
Closed
empiredan
empiredan reviewed Jan 16, 2023
View reviewed changes
src/runtime/task/simple_task_queue.cpp Outdated Show resolved Hide resolved
src/test/kill_test/data_verifier.cpp Outdated Show resolved Hide resolved
src/test/kill_test/data_verifier.cpp Outdated Show resolved Hide resolved
acelyc111 and others added 3 commits January 16, 2023 15:15
@acelyc111 @empiredan
Update src/test/kill_test/data_verifier.cpp
94fb5fa 
Co-authored-by: Dan Wang <wangdan@apache.org>
@acelyc111 @empiredan
Update src/test/kill_test/data_verifier.cpp
62d528a 
Co-authored-by: Dan Wang <wangdan@apache.org>
@acelyc111 @empiredan
Update src/runtime/task/simple_task_queue.cpp
22bd6e5 
Co-authored-by: Dan Wang <wangdan@apache.org>
@empiredan empiredan merged commit 0dcb32f into apache:master Jan 16, 2023
@empiredan empiredan mentioned this pull request Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smityz Smityz Smityz approved these changes

@empiredan empiredan empiredan approved these changes

Assignees
No one assigned
Labels
cpp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acelyc111 @empiredan @Smityz