Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: download hadoop-2.8.4.tar.gz during release building for unit tests once third-parties have changed #1168

Merged

Conversation

empiredan
Copy link
Contributor

@empiredan empiredan commented Sep 22, 2022

This PR is to fix #1164. Once third-parties have changed, image will not be used thus hadoop-2.8.4.tar.gz should be downloaded.

On the other hand, an error was reported as:

image

This told that source should be used since it will quit from return rather than exit, as following code in config_hdfs.sh:

export HADOOP_HOME="${HADOOP_HOME:-${PEGASUS_HADOOP_HOME}}"
if [ ! -d "$HADOOP_HOME/etc/hadoop" ] || [ ! -d "$HADOOP_HOME/share/hadoop" ]; then
  echo "HADOOP_HOME must be set to the location of your Hadoop jars and core-site.xml."
  return 1
fi

Thus in lint_and_test_cpp.yaml, . ./scripts/config_hdfs.sh should be used instead of ./scripts/config_hdfs.sh. The reason for using . rather than source is that the shell is not bash for github workflow: once source is used the workflow will fail with source: not found.

@empiredan empiredan marked this pull request as draft September 23, 2022 04:20
@empiredan empiredan marked this pull request as ready for review September 24, 2022 06:38
@hycdong hycdong merged commit 760c049 into apache:master Sep 27, 2022
@empiredan empiredan mentioned this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download hadoop-2.8.4.tar.gz during release building or third-parties image building for unit tests
3 participants