pegasus_server: refine write process #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shengofsun
previously approved these changes
Jul 9, 2018
neverchanje
previously approved these changes
Jul 9, 2018
neverchanje
reviewed
Jul 9, 2018
src/server/pegasus_server_write.cpp
Outdated
| } | ||
|
|
||
| return on_batched_writes(requests, count, decree); | ||
| return on_batched_writes(requests, count, _decree); |
neverchanje
reviewed
Jul 9, 2018
src/server/pegasus_write_service.cpp
Outdated
| @@ -104,6 +108,8 @@ int pegasus_write_service::batch_remove(int64_t decree, | |||
| const dsn::blob &key, | |||
| dsn::apps::update_response &resp) | |||
| { | |||
| dassert(_batch_start_time != 0, "batch_put must be called after batch_prepare"); | |||
neverchanje
approved these changes
Jul 9, 2018
shengofsun
approved these changes
Jul 9, 2018
neverchanje
pushed a commit
to neverchanje/pegasus
that referenced
this pull request
Jul 13, 2019
Former-commit-id: 425e095d7242972e7b2caf4c26b01625bacd291a [formerly 8ee7e1d] Former-commit-id: 2425bc92bd82dca8a053b80b3503dedde9ea70d1
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.