cr1

apache · Dec 1, 2022 · ef11ad3 · ef11ad3
1 parent 5ec0877
commit ef11ad3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/block_service/fds/fds_service.cpp b/src/block_service/fds/fds_service.cpp
@@ -17,8 +17,7 @@
 
 #include "block_service/fds/fds_service.h"
 
-#include <string.h>
-
+#include <cstring>
 #include <fstream>
 #include <memory>
 

diff --git a/src/runtime/rpc/group_address.h b/src/runtime/rpc/group_address.h
@@ -45,7 +45,7 @@ class rpc_group_address : public ref_counter
     bool add(rpc_address addr); // TODO(yingchun): WARN_UNUSED_RESULT
     void add_list(const std::vector<rpc_address> &addrs)
     {
-        for (const rpc_address &addr : addrs) {
+        for (const auto &addr : addrs) {
             // TODO(yingchun): add LOG_WARNING_IF/LOG_ERROR_IF
             if (!add(addr)) {
                 LOG_WARNING_F("duplicate adress {}", addr);
@@ -54,7 +54,7 @@ class rpc_group_address : public ref_counter
     }
     void set_leader(rpc_address addr);
     bool remove(rpc_address addr);   // TODO(yingchun): WARN_UNUSED_RESULT
-    bool contains(rpc_address addr); // TODO(yingchun): WARN_UNUSED_RESULT
+    bool contains(rpc_address addr) const; // TODO(yingchun): WARN_UNUSED_RESULT
     int count();
 
     const std::vector<rpc_address> &members() const { return _members; }