refactor(idl): unify the *.thrift files used by cpp and nodejs-client (…

…#1335)

.github/workflows/test_nodejs-client.yml

@@ -39,12 +39,17 @@ jobs:
     name: test
     runs-on: ubuntu-20.04
     steps:
+      - name: Install thrift
+        # python-client imports thrift package of 0.13.0, so we must use thrift-compiler 0.13.0
+        # to generate code as well. The thrift-compiler version on ubuntu-20.04 is 0.13.0
+        run: sudo apt-get install -y thrift-compiler
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
           node-version: 16
       - name: test
         working-directory: ./nodejs-client
         run: |
+          ./recompile_thrift.sh
           npm install
           ./test.sh

.licenserc.yaml

@@ -43,7 +43,6 @@ header:
     - 'go-client/idl/base/dsn_err_string.go'
     - 'go-client/idl/base/rocskdb_err_string.go'
     - 'go-client/idl/base/GoUnusedProtection__.go'
-    - 'nodejs-client/src/dsn/*.js'
     - '**/.npmigonre'
     # Copyright (c) Facebook, Inc
     - 'src/utils/TokenBucket.h'

idl/dsn.layer2.thrift

@@ -26,7 +26,6 @@
 
 include "dsn.thrift"
 
-# TODO(yingchun): reuse the idls for server and all client libs
 namespace cpp dsn
 namespace go replication
 namespace java org.apache.pegasus.replication

idl/rrdb.thrift

@@ -324,7 +324,6 @@ service rrdb
     oneway void clear_scanner(1:i64 context_id);
 }
 
-// ONLY FOR GO & JAVA & Python
 service meta
 {
     dsn.layer2.query_cfg_response query_cfg(1:dsn.layer2.query_cfg_request query);