Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: IP white list #2299
Feat: IP white list #2299
Changes from 1 commit
c90bbe9
03583fa
5470e17
2b04f68
4419974
8c43049
a4f3644
73b4c3b
05a861f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 126 in hugegraph-api/src/main/java/org/apache/hugegraph/api/filter/AuthenticationFilter.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/api/filter/AuthenticationFilter.java#L125-L126
Check warning on line 130 in hugegraph-api/src/main/java/org/apache/hugegraph/api/filter/AuthenticationFilter.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/api/filter/AuthenticationFilter.java#L128-L130
Check warning on line 134 in hugegraph-api/src/main/java/org/apache/hugegraph/api/filter/AuthenticationFilter.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/api/filter/AuthenticationFilter.java#L133-L134
Check warning on line 53 in hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java#L53
Check warning on line 55 in hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java#L55
Check warning on line 65 in hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java#L62-L65
Check warning on line 83 in hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java#L78-L83
Check warning on line 86 in hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java#L86
Check warning on line 90 in hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java#L88-L90
Check warning on line 95 in hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java#L92-L95
Check warning on line 99 in hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java#L98-L99
Check warning on line 104 in hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java#L104
Check warning on line 109 in hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java#L107-L109
Check warning on line 111 in hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java#L111
Check warning on line 114 in hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java#L113-L114
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try to set the type of whiteIpList to
Set<String>
Check warning on line 120 in hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java#L116-L120
Check warning on line 122 in hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java#L122
Check warning on line 128 in hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java#L127-L128
Check warning on line 137 in hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java#L137
Check warning on line 145 in hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java#L141-L145
Check warning on line 149 in hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java#L149
Check warning on line 155 in hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/api/profile/WhiteIpListAPI.java#L153-L155
Check warning on line 1573 in hugegraph-api/src/main/java/org/apache/hugegraph/auth/HugeGraphAuthProxy.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/auth/HugeGraphAuthProxy.java#L1573
Check warning on line 1579 in hugegraph-api/src/main/java/org/apache/hugegraph/auth/HugeGraphAuthProxy.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/auth/HugeGraphAuthProxy.java#L1578-L1579
Check warning on line 1583 in hugegraph-api/src/main/java/org/apache/hugegraph/auth/HugeGraphAuthProxy.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/auth/HugeGraphAuthProxy.java#L1583
Check warning on line 1589 in hugegraph-api/src/main/java/org/apache/hugegraph/auth/HugeGraphAuthProxy.java
Codecov / codecov/patch
hugegraph-api/src/main/java/org/apache/hugegraph/auth/HugeGraphAuthProxy.java#L1588-L1589
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mark final
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mark final maybe we cant change it anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for
Object
,final
/static
will just fix the Memory Pointer Address, won't influence the inner valuejust like the head pointer in the linked list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check warning on line 701 in hugegraph-core/src/main/java/org/apache/hugegraph/auth/StandardAuthManager.java
Codecov / codecov/patch
hugegraph-core/src/main/java/org/apache/hugegraph/auth/StandardAuthManager.java#L701
Check warning on line 707 in hugegraph-core/src/main/java/org/apache/hugegraph/auth/StandardAuthManager.java
Codecov / codecov/patch
hugegraph-core/src/main/java/org/apache/hugegraph/auth/StandardAuthManager.java#L706-L707
Check warning on line 711 in hugegraph-core/src/main/java/org/apache/hugegraph/auth/StandardAuthManager.java
Codecov / codecov/patch
hugegraph-core/src/main/java/org/apache/hugegraph/auth/StandardAuthManager.java#L711
Check warning on line 717 in hugegraph-core/src/main/java/org/apache/hugegraph/auth/StandardAuthManager.java
Codecov / codecov/patch
hugegraph-core/src/main/java/org/apache/hugegraph/auth/StandardAuthManager.java#L716-L717