-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-7544][CORE] Add Qualification Tool #8484
Conversation
Run Gluten Clickhouse CI on x86 |
1 similar comment
Run Gluten Clickhouse CI on x86 |
could you help confirm which class/rule do the work that decide whether a operator is supported or not? |
@Yohahaha tools/qualification-tool/src/main/java/org/apache/gluten/qt/support/NodeSupportVisitor.java marks nodes as supported / not supported |
Good feature! It's something we want to have for long time. Would you add a section and a link to main page (https://github.com/apache/incubator-gluten/blob/main/README.md) |
Also can you add an example output file? |
<name>Qualification Tool</name> | ||
|
||
<properties> | ||
<maven.compiler.source>11</maven.compiler.source> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rely on the top level pom's java version here?
Run Gluten Clickhouse CI on x86 |
# Conflicts: # README.md
Run Gluten Clickhouse CI on x86 |
@FelixYBW I have addressed your comments and added sample output. |
Thank you. Let me have a quick try. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you to add the big feature!
Adding a qualification tool that can go through Spark event files and output percentage of the application that can be run using Gluten.
Fixes: #7544