[GLUTEN-7475][VL] fix: remove unnecessary trim function in CAST, cuz velox does it

[Henry2SS]

What changes were proposed in this pull request?

remove unnecessary trim node in CAST, when input type is VARCHAR.

(Fixes: #7475)

How was this patch tested?

Integration tests passed locally. The performance is 1.x times faster.

[github-actions]

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

• Other pull requests

[github-actions]

Run Gluten Clickhouse CI

[github-actions]

Run Gluten Clickhouse CI

[github-actions]

#7476

[github-actions]

#7475

[github-actions]

Run Gluten Clickhouse CI

[PHILO-HE]

@Henry2SS, thanks for your pr! This piece of scala code is for making Gluten/Velox consistent with Spark. Seems the current Velox code doesn't have the consistent white spaces definition? Could you check further?

[Henry2SS]

@Henry2SS, thanks for your pr! This piece of scala code is for making Gluten/Velox consistent with Spark. Seems the current Velox code doesn't have the consistent white spaces definition? Could you check further?

Thanks for your reply!
There is a method called isUnicodeWhiteSpace in velox/functions/lib/string/StringImpl.h.

And I noticed that, from facebookincubator/velox#7377 this PR, the author proposed different corner cases for Presto and Spark on CAST, including removeWhiteSpaces.

Unfortunately, I don't have much knowledge about this, please confirm.

[Henry2SS]

@Henry2SS, thanks for your pr! This piece of scala code is for making Gluten/Velox consistent with Spark. Seems the current Velox code doesn't have the consistent white spaces definition? Could you check further?

And do we have some unit-tests to test CAST from VARCHAR in CI?
Is it possible to confirm it by all the tests in CI?