[VL] update docker script in readme #4683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
PHILO-HE
reviewed
Feb 11, 2024
| #vim ~/.m2/settings.xml | ||
|
|
||
| # the script download velox & arrow and compile all dependency library automatically | ||
| # To access HDFS or S3, you need to add the parameters `--enable_hdfs=ON` and `--enable_s3=ON` | ||
| ./dev/buildbundle-veloxbe.sh | ||
|
|
||
| # It's suggested to build using static link, enabled by --ENABLE_VCPKG=ON |
There was a problem hiding this comment.
We need to use lower case for build option: --enable_vcpkg.
| ./dev/buildbundle-veloxbe.sh | ||
|
|
||
| # It's suggested to build using static link, enabled by --ENABLE_VCPKG=ON | ||
| # For developer, it's suggested to enable Debug info, by --BUILD_TYPE=RelWithDebInfo. Note RelWithDebInfo uses -o2, release uses -o3 |
There was a problem hiding this comment.
--build_type, in lower case.
|
|
||
| # It's suggested to build using static link, enabled by --ENABLE_VCPKG=ON | ||
| # For developer, it's suggested to enable Debug info, by --BUILD_TYPE=RelWithDebInfo. Note RelWithDebInfo uses -o2, release uses -o3 | ||
| ./dev/buildbundle-veloxbe.sh --ENABLE_VCPKG=ON --BUILD_TYPE=RelWithDebInfo |
PHILO-HE
reviewed
Feb 18, 2024
| # For developer, it's suggested to enable Debug info, by --BUILD_TYPE=RelWithDebInfo. Note RelWithDebInfo uses -o2, release uses -o3 | ||
| ./dev/buildbundle-veloxbe.sh --ENABLE_VCPKG=ON --BUILD_TYPE=RelWithDebInfo | ||
| # It's suggested to build using static link, enabled by `--enable_vcpkg=ON` | ||
| # For developer, it's suggested to enable Debug info, by --buld_type=RelWithDebInfo. Note RelWithDebInfo uses -o2, release uses -o3 |
PHILO-HE
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
couple of udpates of script to build gluten in ubuntu20.04/22.04 docker.