Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors in dora plugin #7858

Merged
merged 7 commits into from
Aug 7, 2024
Merged

Fix errors in dora plugin #7858

merged 7 commits into from
Aug 7, 2024

Conversation

d4x1
Copy link
Contributor

@d4x1 d4x1 commented Aug 7, 2024 •
edited
Loading

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?

  1. Fix errors like:
count incidents\n\tcaused by: Error 1054 (42S22): Unknown column 'i.*' in 'field list'\n\tWraps: (2) Error 1054 (42S22): Unknown column 'i.*' in 'field list'\n\tError types: (1) *hintdetail.withDetail (2) *mysql.MySQLError"
  1. Fix dora's subtasks' order

Does this close any open issues?

Closes N/A

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. component/plugins This issue or PR relates to plugins pr-type/bug-fix This PR fixes a bug severity/p1 This bug affects functionality or significantly affect ux labels Aug 7, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Aug 7, 2024
@d4x1 d4x1 changed the title Fix count errors Fix errors in dora plugins Aug 7, 2024
@d4x1 d4x1 changed the title Fix errors in dora plugins Fix errors in dora plugin Aug 7, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 7, 2024
@d4x1 d4x1 merged commit 45a3c97 into main Aug 7, 2024
13 checks passed
@d4x1 d4x1 deleted the dev-2 branch August 7, 2024 07:33
github-actions bot pushed a commit that referenced this pull request Aug 7, 2024
@d4x1
Fix errors in dora plugin (#7858)
b3e57d3 
* fix(dora): add more log in task ConnectIncidentToDeployment

* fix(dora): add select clause in tasks

* fix(dora): add more log

* fix(dora): fix count errors

* fix(dora): fix count errors

* fix(dora): fix wrong subtasks orders
@github-actions github-actions bot mentioned this pull request Aug 7, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

🤖 Target: #release-v1.0 cherry pick finished successfully 🎉!

@github-actions github-actions bot added the bot/auto-cherry-pick-completed auto cherry pick completed label Aug 7, 2024
d4x1 added a commit that referenced this pull request Aug 7, 2024
@github-actions @d4x1
Fix errors in dora plugin (#7858) (#7859)
f711103 
* fix(dora): add more log in task ConnectIncidentToDeployment

* fix(dora): add select clause in tasks

* fix(dora): add more log

* fix(dora): fix count errors

* fix(dora): fix count errors

* fix(dora): fix wrong subtasks orders

Co-authored-by: Lynwee <1507509064@qq.com>
@klesh klesh mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeizn abeizn abeizn approved these changes

Assignees
No one assigned
Labels
bot/auto-cherry-pick-completed auto cherry pick completed component/plugins This issue or PR relates to plugins lgtm This PR has been approved by a maintainer needs-cherrypick-v1.0 pr-type/bug-fix This PR fixes a bug severity/p1 This bug affects functionality or significantly affect ux size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d4x1 @abeizn