-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dora): add incident related tables #7652
Conversation
I am not sure whether this pr should be cherry picked to release-v1.0 or not. |
case OPEN: | ||
return ticket.TODO | ||
case CLOSED: | ||
return ticket.OTHER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLOSE?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And after your PR is merged, devtable will probably need to change the sql uniformly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. CLOSED
pull requests should be OTHER
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* feat(dora): add incident related tables * fix(ci): fix lint/e2e/test errors * fix(ci): fix unit test errors * feat(webhook): issues with type = "INCIDENT" will be stored/updated in table `incidents` * fix(incident): fix method `IsIncident` * feat(dora): add new option `DisableIssueToIncidentGenerator` * fix(dora): fix test
pr-type/bug-fix
,pr-type/feature-development
, etc.Summary
What does this PR do?
incidents
andincident_assignees
incidents
are fromissues
(with type = 'INCIDNET') orpull_requests
(whose lables satisfy some rules, rules are still WIP)project_issue_metrics
toproject_incident_deployment_relationships
ConvertIssuesToIncidents
generates incidents from issuesConvertPullRequestToIncidents
generates incidents from pull_requestsDoes this close any open issues?
Closes N/A
Screenshots
Include any relevant screenshots here.
incident_assignees
incidents
Other Information
Any other information that is important to this PR.