Spark 3.3, 3.4: Migrate TestRewritePositionDeleteFiles to assertJ #8070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nastra @aokolnychyi does this look right? |
nastra
reviewed
Jul 15, 2023
...nsions/src/test/java/org/apache/iceberg/spark/extensions/TestRewritePositionDeleteFiles.java
Outdated
Show resolved
Hide resolved
...nsions/src/test/java/org/apache/iceberg/spark/extensions/TestRewritePositionDeleteFiles.java
Outdated
Show resolved
Hide resolved
dramaticlly
reviewed
Jul 18, 2023
...nsions/src/test/java/org/apache/iceberg/spark/extensions/TestRewritePositionDeleteFiles.java
Outdated
Show resolved
Hide resolved
szehon-ho
force-pushed
the
rewrite_deletes_test_refactor
branch
from
0e8a0a1
to
e970c1d
Compare
|
Thanks for the tips on AssertJ, addressed comments, @dramaticlly @nastra |
nastra
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from comment #8059 (comment)