Core: Remove deprecated AssertHelpers #8062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
approved these changes
Jul 14, 2023
rdblue
reviewed
Aug 23, 2024
| @@ -115,11 +116,10 @@ public void testCherryPickDynamicOverwriteConflict() { | |||
| long lastSnapshotId = table.currentSnapshot().snapshotId(); | |||
|
|
|||
| // pick the snapshot into the current state | |||
| AssertHelpers.assertThrows( | |||
| "Should reject partition replacement when a partition has been modified", | |||
There was a problem hiding this comment.
@nastra, why was this merged when it drops the context from all of these assertions? We took the time to write these context strings that explain what the assertion is testing and I would expect them to be carried forward.
There was a problem hiding this comment.
@rdblue when I reviewed all of these cases the underlying error message was providing enough context to a reader of the test, thus IMHO the additional context felt redundant. Do you see a few places where you'd like to add the additional context back?
Maybe we should improve the error message in those places where we think some additional context is needed to explain the scenario?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all remaining
AssertHelpersiniceberg-coremodule.