Skip to content

Commit

Permalink
Python: Add rm -rf dist/ step
Browse files Browse the repository at this point in the history
To avoid committing the convience artifacts
to the Apache SVN, that should go to PyPi
  • Loading branch information
Fokko committed Jun 29, 2023
1 parent 37900b3 commit b171706
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 3 deletions.
7 changes: 4 additions & 3 deletions python/mkdocs/docs/how-to-release.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,10 @@ export LAST_COMMIT_ID=$(git rev-list ${GIT_TAG} 2> /dev/null | head -n 1)

The `-s` option will sign the commit. If you don't have a key yet, you can find the instructions [here](http://www.apache.org/dev/openpgp.html#key-gen-generate-key). To install gpg on a M1 based Mac, a couple of additional steps are required: https://gist.github.com/phortuin/cf24b1cca3258720c71ad42977e1ba57

Next step is to create a source distribution (`sdist`) which will generate a `.tar.gz` with all the source files. These files need to be uploaded to the Apache SVN.
Next step is to clean remove the `dist/` directory to make sure that we have a clean start. Create a source distribution (`sdist`) which will generate a `.tar.gz` with all the source files using `poetry build`. These files need to be uploaded to the Apache SVN.

```
```sh
rm -rf dist/
poetry build
```

Expand Down Expand Up @@ -94,7 +95,7 @@ poetry build
twine upload -s dist/*
```

Finally step is to generate the email what send to the dev mail list:
Final step is to generate the email to the dev mail list:

```bash
cat << EOF > release-announcement-email.txt
Expand Down
32 changes: 32 additions & 0 deletions python/release-announcement-email.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
To: dev@iceberg.apache.org
Subject: [VOTE] Release Apache PyIceberg 0.4.0
Hi Everyone,

I propose that we release the following RC as the official PyIceberg 0.4.0 release.

The commit ID is 51eaf6806361e6e0a5cd163071dce684ec05350b

* This corresponds to the tag: pyiceberg-0.4.0rc2 (f81c759835672e956c71280394f432463d25463c)
* https://github.com/apache/iceberg/releases/tag/pyiceberg-0.4.0rc2
* https://github.com/apache/iceberg/tree/51eaf6806361e6e0a5cd163071dce684ec05350b

The release tarball, signature, and checksums are here:

* https://dist.apache.org/repos/dist/dev/iceberg/pyiceberg-0.4.0rc2/

You can find the KEYS file here:

* https://dist.apache.org/repos/dist/dev/iceberg/KEYS

Convenience binary artifacts are staged on pypi:

https://pypi.org/project/pyiceberg/0.4.0rc2/

And can be installed using: pip3 install pyiceberg==0.4.0rc2

Please download, verify, and test.

Please vote in the next 72 hours.
[ ] +1 Release this as PyIceberg 0.4.0
[ ] +0
[ ] -1 Do not release this because...

0 comments on commit b171706

Please sign in to comment.