Update VectorHolder unit tests for isDummy method

apache · Sep 26, 2024 · 2bf5b2f · 2bf5b2f
1 parent bbc776d
commit 2bf5b2f
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/arrow/src/test/java/org/apache/iceberg/arrow/vectorized/VectorHolderTest.java b/arrow/src/test/java/org/apache/iceberg/arrow/vectorized/VectorHolderTest.java
@@ -102,14 +102,24 @@ void testDummyHolder() {
   }
 
   @Test
-  void testIsDummy1() {
+  void testIsDummyWithDeletedVectorHolder() {
+    // Test case where vector is null
+    VectorHolder vh = VectorHolder.deletedVectorHolder(0);
+    boolean result = vh.isDummy();
+    Assertions.assertEquals(true, result);
+  }
+
+  @Test
+  void testIsDummyWithDummyHolder() {
+    // Test case where vector is a NullVector instance
     VectorHolder vh = VectorHolder.dummyHolder(0);
     boolean result = vh.isDummy();
     Assertions.assertEquals(true, result);
   }
 
   @Test
-  void testIsDummy2() {
+  void testIsDummyWithConstantVectorHolder() {
+    // Test case where vector is null
     VectorHolder vh = VectorHolder.constantHolder(this.icebergField, 0, "a");
     boolean result = vh.isDummy();
     Assertions.assertEquals(true, result);