Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement datafusion TableProviderFactory #162

Merged
merged 9 commits into from
Oct 14, 2024

Conversation

kazdy
Copy link
Contributor

@kazdy kazdy commented Oct 11, 2024

Description

resolves: #150

This allows datafusion users to register an external hudi table and query it like so:

CREATE EXTERNAL TABLE trips STORED AS HUDI LOCATION 'path';

SELECT * FROM trips;

How are the changes test-covered

  • N/A
  • Automated tests (unit and/or integration tests)
  • Manual tests
    • Details are described below

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.44%. Comparing base (2d0ee12) to head (cbd1c99).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/datafusion/src/lib.rs 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
- Coverage   90.53%   90.44%   -0.09%     
==========================================
  Files          19       19              
  Lines         961      973      +12     
==========================================
+ Hits          870      880      +10     
- Misses         91       93       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kazdy
Copy link
Contributor Author

kazdy commented Oct 13, 2024

@xushiyan can I get another CI run, I added a test for when options are passed to create external table, should make codecov happy

@xushiyan xushiyan added this to the release-0.2.0 milestone Oct 13, 2024
crates/datafusion/src/lib.rs Outdated Show resolved Hide resolved
crates/datafusion/src/lib.rs Outdated Show resolved Hide resolved
@xushiyan
Copy link
Member

@kazdy i'll push quick fixes and then freeze the code for release

@xushiyan xushiyan added the rust Related to Rust codebase label Oct 14, 2024
@kazdy kazdy requested a review from xushiyan October 14, 2024 19:52
@xushiyan xushiyan merged commit abb3e63 into apache:main Oct 14, 2024
10 of 11 checks passed
@xushiyan xushiyan changed the title feat: implement datafusion TableProviderFactory feat: implement datafusion TableProviderFactory Oct 14, 2024
@kazdy kazdy deleted the dftablefactory branch October 14, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature p1 rust Related to Rust codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create HudiTableFactory implementing DataFusions TableProviderFactory
3 participants