Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): upgrade datafusion from 0.41 to 0.42 #149

Merged
merged 4 commits into from
Sep 22, 2024

Conversation

kazdy
Copy link
Contributor

@kazdy kazdy commented Sep 21, 2024

Description

Upgrade datafusion from 0.41 to 0.42 and its dependencies (arrow, pyo3).
gil-refs are deprecated in pyo3 0.22.2, therefore I removed it, it was causing arrow compilation to fail.
Drop support for Python3.8 as it won't receive security updates starting next month.
Bump required python to min. 3.9.

resolves #143

How are the changes test-covered

  • N/A
  • Automated tests (unit and/or integration tests)
  • Manual tests
    • Details are described below

@kazdy
Copy link
Contributor Author

kazdy commented Sep 21, 2024

Datafusion plan changed a bit:
image

Copy link
Member

@xushiyan xushiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to upgrade python version too. having 1 question on pyarrow

python/pyproject.toml Outdated Show resolved Hide resolved
@kazdy kazdy changed the title build(deps): Upgrade datafusion from 0.41 to 0.42 build(deps): upgrade datafusion from 0.41 to 0.42 Sep 22, 2024
@kazdy kazdy requested a review from xushiyan September 22, 2024 13:15
@xushiyan xushiyan added this to the release-0.2.0 milestone Sep 22, 2024
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.82%. Comparing base (e23e6ed) to head (1246489).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #149   +/-   ##
=======================================
  Coverage   87.82%   87.82%           
=======================================
  Files          14       14           
  Lines         731      731           
=======================================
  Hits          642      642           
  Misses         89       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

python/pyproject.toml Outdated Show resolved Hide resolved
@kazdy kazdy requested a review from xushiyan September 22, 2024 17:29
@xushiyan xushiyan merged commit 5e1981f into apache:main Sep 22, 2024
9 checks passed
@kazdy kazdy deleted the 143-upgrade-dependencies branch September 22, 2024 17:41
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12"
]
dependencies = [
"pyarrow>=8",
"pyarrow>=11.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to update in-code version check also, in test_table_read.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade arrow-rs, object_store, datafusion, pyo3 versions
2 participants