Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract common test code for creating table #117

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

gohalo
Copy link
Contributor

@gohalo gohalo commented Aug 21, 2024

Description

Use a common test function to create fixture Table without running config validation.

How are the changes test-covered

  • N/A
  • Automated tests (unit and/or integration tests)
  • Manual tests
    • Details are described below

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.77%. Comparing base (01ef2fc) to head (328db23).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #117   +/-   ##
=======================================
  Coverage   87.77%   87.77%           
=======================================
  Files          14       14           
  Lines         728      728           
=======================================
  Hits          639      639           
  Misses         89       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiyan
Copy link
Member

@gohalo thanks for the PR. i've decided to refactor #118 instead which is easier to do. Can you pls update this PR to keep the test code refactoring change? then we can merge this.

@xushiyan xushiyan changed the title feat: support external config hudi-defaults.conf refactor: extract common test code for creating table Sep 13, 2024
@xushiyan xushiyan added this to the release-0.2.0 milestone Sep 13, 2024
@xushiyan xushiyan added refactor Code refactoring without any functionality or behavior change rust Related to Rust codebase labels Sep 13, 2024
@xushiyan xushiyan merged commit 869607d into apache:main Sep 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code refactoring without any functionality or behavior change rust Related to Rust codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants