Skip to content

Commit

Permalink
remove datafusion common in core default and update by advice
Browse files Browse the repository at this point in the history
  • Loading branch information
KnightChess committed Sep 18, 2024
1 parent a150e7c commit 2890fee
Show file tree
Hide file tree
Showing 6 changed files with 79 additions and 144 deletions.
2 changes: 2 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ homepage = "https://github.com/apache/hudi-rs"
repository = "https://github.com/apache/hudi-rs"

[workspace.dependencies]
log = "^0.4"

# arrow
arrow = { version = "= 52.2.0", features = ["pyarrow"] }
arrow-arith = { version = "= 52.2.0" }
Expand Down
4 changes: 2 additions & 2 deletions crates/core/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@ tokio = { workspace = true }
# datafusion
datafusion = { workspace = true, optional = true }
datafusion-expr = { workspace = true, optional = true }
datafusion-common = { workspace = true }
datafusion-common = { workspace = true, optional = true }
datafusion-physical-expr = { workspace = true, optional = true }
log = "0.4.22"
log = { workspace = true}

[dev-dependencies]
hudi-tests = { path = "../tests" }
Expand Down
2 changes: 1 addition & 1 deletion crates/core/src/config/table.rs
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,8 @@ impl ConfigParser for HudiTableConfig {
match self {
Self::DatabaseName => Some(HudiConfigValue::String("default".to_string())),
Self::DropsPartitionFields => Some(HudiConfigValue::Boolean(false)),
Self::PopulatesMetaFields => Some(HudiConfigValue::Boolean(true)),
Self::PartitionFields => Some(HudiConfigValue::List(vec!["".to_string()])),
Self::PopulatesMetaFields => Some(HudiConfigValue::Boolean(true)),
_ => None,
}
}
Expand Down
1 change: 0 additions & 1 deletion crates/core/src/table/fs_view.rs
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,6 @@ impl FileSystemView {
}
}
}
assert!(!self.partition_to_file_groups.is_empty());
Ok(file_slices)
}

Expand Down
1 change: 1 addition & 0 deletions crates/core/src/table/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,7 @@ impl Table {
}
}

#[cfg(test)]
pub fn reset(&mut self) {
self.file_system_view.reset()
}
Expand Down
Loading

0 comments on commit 2890fee

Please sign in to comment.