Minor performance optimization of response out of sequence check

apache · Jun 2, 2024 · 29b0173 · 29b0173
1 parent 939d4b2
commit 29b0173
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/DefaultBHttpClientConnection.java b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/DefaultBHttpClientConnection.java
@@ -113,8 +113,7 @@ public DefaultBHttpClientConnection(
             DefaultContentLengthStrategy.INSTANCE;
         this.outgoingContentStrategy = outgoingContentStrategy != null ? outgoingContentStrategy :
             DefaultContentLengthStrategy.INSTANCE;
-        this.responseOutOfOrderStrategy = responseOutOfOrderStrategy != null ? responseOutOfOrderStrategy :
-            NoResponseOutOfOrderStrategy.INSTANCE;
+        this.responseOutOfOrderStrategy = responseOutOfOrderStrategy;
         this.consistent = true;
     }
 
@@ -220,21 +219,27 @@ void checkForEarlyResponse(final long totalBytesSent, final int nextWriteSize) t
 
                     @Override
                     public void write(final byte[] b) throws IOException {
-                        checkForEarlyResponse(totalBytes, b.length);
+                        if (responseOutOfOrderStrategy != null) {
+                            checkForEarlyResponse(totalBytes, b.length);
+                        }
                         totalBytes += b.length;
                         socketOutputStream.write(b);
                     }
 
                     @Override
                     public void write(final byte[] b, final int off, final int len) throws IOException {
-                        checkForEarlyResponse(totalBytes, len);
+                        if (responseOutOfOrderStrategy != null) {
+                            checkForEarlyResponse(totalBytes, len);
+                        }
                         totalBytes += len;
                         socketOutputStream.write(b, off, len);
                     }
 
                     @Override
                     public void write(final int b) throws IOException {
-                        checkForEarlyResponse(totalBytes, 1);
+                        if (responseOutOfOrderStrategy != null) {
+                            checkForEarlyResponse(totalBytes, 1);
+                        }
                         totalBytes++;
                         socketOutputStream.write(b);
                     }