feat: build sst in stream way #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #747 +/- ##
==========================================
+ Coverage 68.43% 68.56% +0.12%
==========================================
Files 294 293 -1
Lines 45712 45628 -84
==========================================
+ Hits 31284 31285 +1
+ Misses 14428 14343 -85
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I guess features should be tested against OSS. |
jiacai2050
reviewed
Mar 17, 2023
jiacai2050
reviewed
Mar 17, 2023
jiacai2050
reviewed
Mar 17, 2023
jiacai2050
reviewed
Mar 17, 2023
jiacai2050
reviewed
Mar 20, 2023
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* feat: support build sst in stream way * use AsyncWrite for building sst procedure * shutdown when close the async writer * build sst in streaming way * find the custom metadata * better names * add config for write sst max buffer size * polish up some comments * address CR * fix license header * use readable size for write_sst_max_buffer_size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #486
Rationale for this change
Refer to #486
What changes are included in this PR?
AsyncArrowWriterin theparquet_extcrate;AsyncArrowWriter;Are there any user-facing changes?
None.
How does this change test
Existing tests.